Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 163953008: Remove the animation delay for showing the top level apps when user opens app list launcher. (Closed)

Created:
6 years, 10 months ago by jennyz
Modified:
6 years, 10 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Visibility:
Public.

Description

Remove the animation delay for showing the top level apps when user opens app list launcher. The animation will be performed only when user return to the top level apps grid view from a folder view. BUG=336187 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251299

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move show/hide and animation logic for the views from Layout to SetShowState. #

Patch Set 3 : Move show/hide and animation logic for the views from Layout to SetShowState. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -17 lines) Patch
M ui/app_list/views/app_list_folder_view.h View 2 chunks +3 lines, -1 line 0 comments Download
M ui/app_list/views/app_list_folder_view.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/app_list/views/apps_container_view.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/apps_container_view.cc View 1 5 chunks +36 lines, -15 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
jennyz
6 years, 10 months ago (2014-02-13 22:30:42 UTC) #1
jennyz
6 years, 10 months ago (2014-02-13 22:32:01 UTC) #2
xiyuan
https://codereview.chromium.org/163953008/diff/1/ui/app_list/views/apps_container_view.cc File ui/app_list/views/apps_container_view.cc (right): https://codereview.chromium.org/163953008/diff/1/ui/app_list/views/apps_container_view.cc#newcode103 ui/app_list/views/apps_container_view.cc:103: apps_grid_view_->SetVisible(true); Can we move the animation and show/hide code ...
6 years, 10 months ago (2014-02-13 22:53:42 UTC) #3
jennyz
https://codereview.chromium.org/163953008/diff/1/ui/app_list/views/apps_container_view.cc File ui/app_list/views/apps_container_view.cc (right): https://codereview.chromium.org/163953008/diff/1/ui/app_list/views/apps_container_view.cc#newcode103 ui/app_list/views/apps_container_view.cc:103: apps_grid_view_->SetVisible(true); On 2014/02/13 22:53:42, xiyuan wrote: > Can we ...
6 years, 10 months ago (2014-02-13 23:42:58 UTC) #4
jennyz
6 years, 10 months ago (2014-02-14 00:02:09 UTC) #5
xiyuan
lgtm
6 years, 10 months ago (2014-02-14 00:10:11 UTC) #6
jennyz
The CQ bit was checked by jennyz@chromium.org
6 years, 10 months ago (2014-02-14 00:11:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/163953008/90001
6 years, 10 months ago (2014-02-14 00:15:15 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 02:09:15 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) ash_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=263945
6 years, 10 months ago (2014-02-14 02:09:15 UTC) #10
jennyz
The CQ bit was checked by jennyz@chromium.org
6 years, 10 months ago (2014-02-14 04:59:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/163953008/90001
6 years, 10 months ago (2014-02-14 04:59:31 UTC) #12
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 14:00:48 UTC) #13
Message was sent while issue was closed. 
Change committed as 251299

Powered by Google App Engine
This is Rietveld 408576698