Issue 163953006: Convert AvatarLabel from TextButton to LabelButton.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 163953006: Convert AvatarLabel from TextButton to LabelButton. (Closed)

Created:
6 years, 10 months ago by msw

Modified:
6 years, 10 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Convert AvatarLabel from TextButton to LabelButton. TextButton will be deprecated soon; use LabelButton. Use views::Border as the AvatarLabelBorder base class. Other minor cleanup. BUG=155363 TEST=No regressions of this Windows/CrOS/LinuxAura supervised user UI. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251241

Patch Set 1 #

Patch Set 2 : Convert AvatarLabel from TextButton to LabelButton. #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -34 lines)			Patch
	M	chrome/browser/ui/views/avatar_label.h	View		1 chunk	+3 lines, -8 lines	0 comments	Download
	M	chrome/browser/ui/views/avatar_label.cc	View	1	7 chunks	+22 lines, -26 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/163953006/40001

6 years, 10 months ago (2014-02-13 23:20:22 UTC) #4

Message was sent while issue was closed.

Change committed as 251241

Expand Messages | Collapse Messages