Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1639513002: MD Downloads: strip combined, minified JS from vulcanized output (Closed)

Created:
4 years, 11 months ago by Dan Beam
Modified:
4 years, 10 months ago
Reviewers:
Nico, michaelpg
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: strip combined, minified JS from vulcanized output Duplicating these resources were adding too much size to Chrome compared to the performance benefit they add. In my cursory perf testing I saw no tangible difference, but I still need to test on memory constrained systems. Shrinks crisper.js by 44.4% and gzipped copy by 43%. R=michaelpg@chromium.org BUG=541455 Committed: https://crrev.com/02fdf984fa1da0c3c521c46252ac186b7cc45436 Cr-Commit-Position: refs/heads/master@{#371610}

Patch Set 1 #

Patch Set 2 : web-animations-js + licensing #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -7290 lines) Patch
M chrome/browser/resources/md_downloads/crisper.js View 1 3 chunks +0 lines, -7285 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanize.py View 1 1 chunk +12 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 3 chunks +15 lines, -1 line 4 comments Download
M tools/copyright_scanner/third_party_files_whitelist.txt View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 23 (11 generated)
Dan Beam
4 years, 11 months ago (2016-01-25 20:56:10 UTC) #1
michaelpg
not bad
4 years, 11 months ago (2016-01-25 21:51:43 UTC) #2
Dan Beam
aight, also excluded web-animations-js and think this is ready for real review (not a ton ...
4 years, 11 months ago (2016-01-26 01:57:46 UTC) #9
michaelpg
https://codereview.chromium.org/1639513002/diff/20001/chrome/browser/resources/md_downloads/vulcanized.html File chrome/browser/resources/md_downloads/vulcanized.html (right): https://codereview.chromium.org/1639513002/diff/20001/chrome/browser/resources/md_downloads/vulcanized.html#newcode830 chrome/browser/resources/md_downloads/vulcanized.html:830: wat
4 years, 11 months ago (2016-01-26 05:05:58 UTC) #10
Dan Beam
https://codereview.chromium.org/1639513002/diff/20001/chrome/browser/resources/md_downloads/vulcanized.html File chrome/browser/resources/md_downloads/vulcanized.html (right): https://codereview.chromium.org/1639513002/diff/20001/chrome/browser/resources/md_downloads/vulcanized.html#newcode830 chrome/browser/resources/md_downloads/vulcanized.html:830: On 2016/01/26 05:05:58, michaelpg wrote: > wat ¯\_(ツ)_/¯ I ...
4 years, 10 months ago (2016-01-26 17:20:01 UTC) #11
michaelpg
lgtm https://codereview.chromium.org/1639513002/diff/20001/chrome/browser/resources/md_downloads/vulcanized.html File chrome/browser/resources/md_downloads/vulcanized.html (right): https://codereview.chromium.org/1639513002/diff/20001/chrome/browser/resources/md_downloads/vulcanized.html#newcode830 chrome/browser/resources/md_downloads/vulcanized.html:830: On 2016/01/26 17:20:00, Dan Beam wrote: > On ...
4 years, 10 months ago (2016-01-26 20:21:54 UTC) #13
Dan Beam
https://codereview.chromium.org/1639513002/diff/20001/chrome/browser/resources/md_downloads/vulcanized.html File chrome/browser/resources/md_downloads/vulcanized.html (right): https://codereview.chromium.org/1639513002/diff/20001/chrome/browser/resources/md_downloads/vulcanized.html#newcode830 chrome/browser/resources/md_downloads/vulcanized.html:830: On 2016/01/26 20:21:54, michaelpg wrote: > On 2016/01/26 17:20:00, ...
4 years, 10 months ago (2016-01-26 20:28:31 UTC) #14
Dan Beam
+thakis for tools/ stamp
4 years, 10 months ago (2016-01-26 20:29:20 UTC) #16
Nico
lgtm
4 years, 10 months ago (2016-01-26 21:11:25 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639513002/20001
4 years, 10 months ago (2016-01-26 21:17:08 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-26 22:05:58 UTC) #21
commit-bot: I haz the power
4 years, 10 months ago (2016-01-26 22:06:59 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/02fdf984fa1da0c3c521c46252ac186b7cc45436
Cr-Commit-Position: refs/heads/master@{#371610}

Powered by Google App Engine
This is Rietveld 408576698