Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1639503002: Change USBTransferInResult.data to a DataView. (Closed)

Created:
4 years, 11 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 11 months ago
Reviewers:
juncai
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change USBTransferInResult.data to a DataView. This modification is copied from Web Bluetooth where it was found to be more ergonomic to provide a DataView as the default type for a buffer value as it provides methods such as getUint8() by default. BUG=492204 Committed: https://crrev.com/426b5b601387ae458592dab96c0e2b18b7ba1e70 Cr-Commit-Position: refs/heads/master@{#371560}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M third_party/WebKit/Source/modules/webusb/USBInTransferResult.h View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBInTransferResult.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Reilly Grant (use Gerrit)
Please take a look.
4 years, 11 months ago (2016-01-25 20:36:25 UTC) #3
juncai
LGTM.
4 years, 11 months ago (2016-01-25 21:15:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639503002/1
4 years, 11 months ago (2016-01-26 19:28:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 19:36:18 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 19:37:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/426b5b601387ae458592dab96c0e2b18b7ba1e70
Cr-Commit-Position: refs/heads/master@{#371560}

Powered by Google App Engine
This is Rietveld 408576698