Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1639493003: Add extensions parameter to Pylint presubmit check. (Closed)

Created:
4 years, 11 months ago by dtu
Modified:
4 years, 11 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add extensions parameter to Pylint presubmit check. This allows Pylint to analyze code that relies on C extensions (like numpy). https://bitbucket.org/logilab/pylint/issues/58#comment-14920640 BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298392

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M presubmit_canned_checks.py View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dtu
4 years, 11 months ago (2016-01-25 23:47:07 UTC) #2
Dirk Pranke
lgtm
4 years, 11 months ago (2016-01-25 23:50:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639493003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639493003/1
4 years, 11 months ago (2016-01-25 23:52:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=298392
4 years, 11 months ago (2016-01-25 23:54:29 UTC) #7
dtu
4 years, 11 months ago (2016-01-27 20:06:47 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1646633002/ by dtu@chromium.org.

The reason for reverting is: Sorry, turns out this change isn't necessary. You
can specify extension-pkg-whitelist in pylintrc..

Powered by Google App Engine
This is Rietveld 408576698