Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1639483002: Revert "Revert of CT Verify test utilities change - Moved the following common functions (patchset … (Closed)

Created:
4 years, 11 months ago by Eran Messeri
Modified:
4 years, 11 months ago
CC:
chromium-reviews, certificate-transparency-chrome_googlegroups.com, cbentzel+watch_chromium.org, Eran Messeri
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Revert of CT Verify test utilities change - Moved the following common functions (patchset #1 id:1 of https://codereview.chromium.org/1498983004/ )" This reverts commit 13cb74df2cc9b14ab70598d80241a5ec919ca688. BUG=568282 Committed: https://crrev.com/d372eb96f80c84cb73413fa014a35d7de41607d8 Cr-Commit-Position: refs/heads/master@{#371334}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -74 lines) Patch
M net/cert/multi_log_ct_verifier_unittest.cc View 5 chunks +10 lines, -41 lines 0 comments Download
M net/quic/crypto/proof_verifier_chromium_test.cc View 3 chunks +5 lines, -31 lines 0 comments Download
M net/test/ct_test_util.h View 2 chunks +19 lines, -1 line 0 comments Download
M net/test/ct_test_util.cc View 2 chunks +33 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Eran Messeri
4 years, 11 months ago (2016-01-25 19:23:31 UTC) #3
ramant (doing other things)
lgtm
4 years, 11 months ago (2016-01-25 19:34:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639483002/1
4 years, 11 months ago (2016-01-25 21:27:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-25 22:15:40 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 22:18:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d372eb96f80c84cb73413fa014a35d7de41607d8
Cr-Commit-Position: refs/heads/master@{#371334}

Powered by Google App Engine
This is Rietveld 408576698