Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1639463002: Moves HistoryIndexRestoreObserver to components/omnibox/browser. (Closed)

Created:
4 years, 10 months ago by rohitrao (ping after 24h)
Modified:
4 years, 10 months ago
CC:
chromium-reviews, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves HistoryIndexRestoreObserver to components/omnibox/browser. BUG=None TEST=None Committed: https://crrev.com/21f9a9b486e880c78da6b937b7a8241a3d842360 Cr-Commit-Position: refs/heads/master@{#371628}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -62 lines) Patch
M chrome/browser/autocomplete/in_memory_url_index_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/test/base/history_index_restore_observer.h View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/test/base/history_index_restore_observer.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/omnibox.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/omnibox/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + components/omnibox/browser/history_index_restore_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/omnibox/browser/history_index_restore_observer.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Issue 1635653002 Patch 1
Issue 1635653002 Patch 20001

Messages

Total messages: 18 (7 generated)
rohitrao (ping after 24h)
I'd like to use this observer from a unittest in components/omnibox/browser. I'm splitting out the ...
4 years, 10 months ago (2016-01-25 19:31:28 UTC) #2
Peter Kasting
LGTM
4 years, 10 months ago (2016-01-26 02:07:31 UTC) #3
blundell
lgtm
4 years, 10 months ago (2016-01-26 08:35:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639463002/1
4 years, 10 months ago (2016-01-26 13:34:49 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/139037)
4 years, 10 months ago (2016-01-26 13:42:58 UTC) #8
rohitrao (ping after 24h)
+phajdan.jr for OWNERS approval in chrome/test.
4 years, 10 months ago (2016-01-26 14:04:56 UTC) #10
rohitrao (ping after 24h)
Also adding sky@ for OWNERS approval of chrome/test, since it's after work hours for the ...
4 years, 10 months ago (2016-01-26 17:46:33 UTC) #12
sky
chrome/test LGTM
4 years, 10 months ago (2016-01-26 21:45:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639463002/1
4 years, 10 months ago (2016-01-26 21:54:28 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-26 23:09:55 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-01-26 23:11:09 UTC) #18
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/21f9a9b486e880c78da6b937b7a8241a3d842360
Cr-Commit-Position: refs/heads/master@{#371628}

Powered by Google App Engine
This is Rietveld 408576698