Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Issue 1639443002: Changes to public.bzl to support building on iOS with objc_library bazel target. (Closed)

Created:
4 years, 11 months ago by iroth
Modified:
4 years, 11 months ago
Reviewers:
dogben, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Changes to public.bzl to support building on iOS with objc_library bazel target. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1639443002 Committed: https://skia.googlesource.com/skia/+/d2ccc772d4fb4d1ad97024f95d61de79e4c9954e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M public.bzl View 6 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
iroth
4 years, 11 months ago (2016-01-25 19:10:10 UTC) #4
mtklein
lgtm looks familiar!
4 years, 11 months ago (2016-01-25 19:10:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639443002/1
4 years, 11 months ago (2016-01-25 19:11:01 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 19:25:00 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d2ccc772d4fb4d1ad97024f95d61de79e4c9954e

Powered by Google App Engine
This is Rietveld 408576698