Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 163943005: Remove CloudPrintAccountManager. (Closed)

Created:
6 years, 10 months ago by Noam Samuel
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove CloudPrintAccountManager. It is an unused class from back when we thought we may want to have multi-account support in the devices page. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251223

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -241 lines) Patch
D chrome/browser/local_discovery/cloud_print_account_manager.h View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/local_discovery/cloud_print_account_manager.cc View 1 chunk +0 lines, -84 lines 0 comments Download
D chrome/browser/local_discovery/cloud_print_account_manager_unittest.cc View 1 chunk +0 lines, -104 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Noam Samuel
6 years, 10 months ago (2014-02-13 20:45:03 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 10 months ago (2014-02-13 23:00:40 UTC) #2
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 10 months ago (2014-02-13 23:00:45 UTC) #3
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 10 months ago (2014-02-13 23:01:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/163943005/1
6 years, 10 months ago (2014-02-13 23:02:41 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 01:27:52 UTC) #6
Message was sent while issue was closed.
Change committed as 251223

Powered by Google App Engine
This is Rietveld 408576698