Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1639393002: Use static_cast instead of reinterpret_cast in net::ReadHeader. (Closed)

Created:
4 years, 10 months ago by Will Harris
Modified:
4 years, 10 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use static_cast instead of reinterpret_cast in net::ReadHeader. static_cast should be used when casting within a class hierarchy. BUG=None Committed: https://crrev.com/ad660438b1ff03bfd146b0b4f8165ce926133422 Cr-Commit-Position: refs/heads/master@{#371855}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/cert/crl_set_storage.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
Will Harris
4 years, 10 months ago (2016-01-27 18:42:43 UTC) #3
Ryan Sleevi
lgtm
4 years, 10 months ago (2016-01-27 19:06:38 UTC) #6
Will Harris
*achievement unlocked*: lgtm from sleevi with no comments.
4 years, 10 months ago (2016-01-27 19:07:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639393002/1
4 years, 10 months ago (2016-01-27 19:07:36 UTC) #8
Ryan Sleevi
On 2016/01/27 19:07:19, Will Harris wrote: > *achievement unlocked*: lgtm from sleevi with no comments. ...
4 years, 10 months ago (2016-01-27 19:09:04 UTC) #9
Will Harris
On 2016/01/27 19:09:04, Ryan Sleevi wrote: > On 2016/01/27 19:07:19, Will Harris wrote: > > ...
4 years, 10 months ago (2016-01-27 19:09:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-27 20:26:24 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-01-27 20:27:20 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ad660438b1ff03bfd146b0b4f8165ce926133422
Cr-Commit-Position: refs/heads/master@{#371855}

Powered by Google App Engine
This is Rietveld 408576698