|
|
Chromium Code Reviews
DescriptionRe-enable page_cycler.intl_ko_th_vi on android.
BUG=506903
Committed: https://crrev.com/eb6cbd585bd0d618af38ddd62ef0e6974ba0a4e3
Cr-Commit-Position: refs/heads/master@{#372085}
Patch Set 1 #
Messages
Total messages: 36 (17 generated)
Description was changed from ========== Re-enable page_cycler.intl_ko_th_vi on android. BUG=506903 ========== to ========== Re-enable page_cycler.intl_ko_th_vi on android. BUG=506903 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect ==========
The CQ bit was checked by sullivan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639353002/1
sullivan@chromium.org changed reviewers: + prasadv@chromium.org
Prasad, this benchmark may be broken on N5 and N7v2. Can I just add those to CQ_EXTRA_TRYBOTS and do a CQ dryrun to check if it passes?
lgtm
On 2016/01/27 16:56:29, prasadv wrote: > lgtm ping on question about how to add an android device to CQ_EXTRA_TRYBOTS?
On 2016/01/27 16:57:00, sullivan wrote: > On 2016/01/27 16:56:29, prasadv wrote: > > lgtm > > ping on question about how to add an android device to CQ_EXTRA_TRYBOTS? Sorry, I disabled android on CQ_EXTRA_TRYBOTS due to crbug.com/568661, but now that move is complete I'll upload a patch to re-enable it on CQ. Meanwhile we can edit this CL to include tryserver.chromium.perf:android_nexus5_perf_bisect in CQ_EXTRA_TRYBOTS
Description was changed from ========== Re-enable page_cycler.intl_ko_th_vi on android. BUG=506903 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect ========== to ========== Re-enable page_cycler.intl_ko_th_vi on android. BUG=506903 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect ==========
Done, thanks! Will do another CQ dry run when this one completes.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_10_10_perf_bisect on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) win_perf_bisect on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by sullivan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639353002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_nexus5_perf_bisect on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by sullivan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639353002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_10_10_perf_bisect on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) win_perf_bisect on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by sullivan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639353002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_nexus5_perf_bisect on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) win_perf_bisect on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by sullivan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639353002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_nexus5_perf_bisect on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
Description was changed from ========== Re-enable page_cycler.intl_ko_th_vi on android. BUG=506903 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect ========== to ========== Re-enable page_cycler.intl_ko_th_vi on android. BUG=506903 ==========
Got the benchmark passing here, so we'll try submitting: https://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5_... I'm deleting the CQ_EXTRA_TRYBOTS because scheduling them often fails until crbug.com/571169 is fixed.
The CQ bit was checked by sullivan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639353002/1
Message was sent while issue was closed.
Description was changed from ========== Re-enable page_cycler.intl_ko_th_vi on android. BUG=506903 ========== to ========== Re-enable page_cycler.intl_ko_th_vi on android. BUG=506903 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Re-enable page_cycler.intl_ko_th_vi on android. BUG=506903 ========== to ========== Re-enable page_cycler.intl_ko_th_vi on android. BUG=506903 Committed: https://crrev.com/eb6cbd585bd0d618af38ddd62ef0e6974ba0a4e3 Cr-Commit-Position: refs/heads/master@{#372085} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/eb6cbd585bd0d618af38ddd62ef0e6974ba0a4e3 Cr-Commit-Position: refs/heads/master@{#372085} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
