Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1639343005: [generators] Implement Generator.prototype.return. (Closed)

Created:
4 years, 10 months ago by neis
Modified:
4 years, 10 months ago
CC:
rossberg, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@yield-star
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[generators] Implement Generator.prototype.return. Note: This is currently only used by yield*, we still need to support it in other places (such as for-of loops). It can be used manually of course. (This CL does not touch the full-codegen implementation of yield* because that code is already dead. The yield* desugaring already supports return and doesn't need to be touched.) BUG=v8:3566 LOG=y Committed: https://crrev.com/dbd86408134e67551c1e66c3a7484abb628b95f7 Cr-Commit-Position: refs/heads/master@{#33744}

Patch Set 1 #

Patch Set 2 : Rebase and resolve dependency #

Patch Set 3 : Another rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+415 lines, -37 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 2 3 chunks +12 lines, -1 line 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 2 3 chunks +12 lines, -1 line 0 comments Download
M src/full-codegen/full-codegen.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 2 3 chunks +12 lines, -1 line 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 3 chunks +12 lines, -1 line 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 3 chunks +12 lines, -1 line 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 2 4 chunks +14 lines, -3 lines 0 comments Download
M src/js/generator.js View 4 chunks +28 lines, -3 lines 0 comments Download
M src/objects.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/parsing/parser.cc View 1 2 6 chunks +11 lines, -10 lines 0 comments Download
M src/runtime/runtime.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-generator.cc View 1 3 chunks +20 lines, -7 lines 0 comments Download
M test/mjsunit/es6/generators-runtime.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/function-sent.js View 2 chunks +18 lines, -4 lines 0 comments Download
A test/mjsunit/harmony/generators.js View 1 chunk +252 lines, -0 lines 0 comments Download
M test/test262/test262.status View 1 2 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639343005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639343005/1
4 years, 10 months ago (2016-01-28 13:59:42 UTC) #2
neis
PTAL. This is https://codereview.chromium.org/1639343005/ based on top of the yield* desugaring.
4 years, 10 months ago (2016-01-28 14:21:03 UTC) #5
neis
On 2016/01/28 14:21:03, neis wrote: > PTAL. > > This is https://codereview.chromium.org/1639343005/ based on top ...
4 years, 10 months ago (2016-01-28 14:21:48 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-28 14:28:05 UTC) #8
Jarin
lgtm
4 years, 10 months ago (2016-02-01 07:53:44 UTC) #9
Michael Starzinger
LGTM.
4 years, 10 months ago (2016-02-01 10:16:14 UTC) #10
neis
@Dan: Please have a look at src/js changes.
4 years, 10 months ago (2016-02-04 15:52:02 UTC) #13
Dan Ehrenberg
lgtm LGTM for js code
4 years, 10 months ago (2016-02-04 16:03:06 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639343005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639343005/40001
4 years, 10 months ago (2016-02-04 16:45:00 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-04 17:13:46 UTC) #19
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 17:14:21 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/dbd86408134e67551c1e66c3a7484abb628b95f7
Cr-Commit-Position: refs/heads/master@{#33744}

Powered by Google App Engine
This is Rietveld 408576698