Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Issue 1639333002: switched to SkJSONCPP for JSON output (Closed)

Created:
4 years, 11 months ago by ethannicholas
Modified:
4 years, 11 months ago
Reviewers:
joshualitt, jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -256 lines) Patch
M tools/json/SkJSONCanvas.h View 3 chunks +17 lines, -22 lines 0 comments Download
M tools/json/SkJSONCanvas.cpp View 4 chunks +239 lines, -233 lines 0 comments Download
M tools/json/SkJSONRenderer.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639333002/20001
4 years, 11 months ago (2016-01-27 16:25:29 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/5671)
4 years, 11 months ago (2016-01-27 16:27:37 UTC) #6
ethannicholas
4 years, 11 months ago (2016-01-27 16:41:49 UTC) #8
joshualitt
On 2016/01/27 16:41:49, ethannicholas wrote: lgtm
4 years, 11 months ago (2016-01-27 16:54:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639333002/20001
4 years, 11 months ago (2016-01-27 16:55:31 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/5673)
4 years, 11 months ago (2016-01-27 16:57:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639333002/20001
4 years, 11 months ago (2016-01-27 17:04:07 UTC) #15
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 17:06:38 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://skia.googlesource.com/skia/+/2bbc343c148218c0f47e155ffc6f2ebfbfe05a76

Powered by Google App Engine
This is Rietveld 408576698