Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: Source/web/WebViewImpl.cpp

Issue 163933002: Send early ShowPress on TapDown when page isn't scrollable/pinchable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/page/EventHandler.cpp ('K') | « Source/web/ChromeClientImpl.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebViewImpl.cpp
diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp
index ebc75115e5f198aaa7ed25cdf679f102931bcd92..b1ec7a90b2f8685c655b622f885a6dc1de785f2b 100644
--- a/Source/web/WebViewImpl.cpp
+++ b/Source/web/WebViewImpl.cpp
@@ -1107,7 +1107,11 @@ Node* WebViewImpl::bestTapNode(const PlatformGestureEvent& tapEvent)
m_page->mainFrame()->eventHandler().adjustGesturePosition(tapEvent, touchEventLocation);
IntPoint hitTestPoint = m_page->mainFrame()->view()->windowToContents(touchEventLocation);
- HitTestResult result = m_page->mainFrame()->eventHandler().hitTestResultAtPoint(hitTestPoint, HitTestRequest::TouchEvent | HitTestRequest::ConfusingAndOftenMisusedDisallowShadowContent);
+ EventHandler& eventHandler = m_page->mainFrame()->eventHandler();
+ HitTestRequest::HitTestRequestType hitType = HitTestRequest::TouchEvent | HitTestRequest::ConfusingAndOftenMisusedDisallowShadowContent;
+ if (eventHandler.tapDownTriggeredActive())
+ hitType |= HitTestRequest::ReadOnly;
Rick Byers 2014/02/14 21:27:53 Does this normally need to be non-readonly so that
+ HitTestResult result = eventHandler.hitTestResultAtPoint(hitTestPoint, hitType);
bestTouchNode = result.targetNode();
// We might hit something like an image map that has no renderer on it
« Source/core/page/EventHandler.cpp ('K') | « Source/web/ChromeClientImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698