Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Side by Side Diff: Source/web/WebViewImpl.h

Issue 163933002: Send early ShowPress on TapDown when page isn't scrollable/pinchable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Refactor into hasEarlyShowPress() Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/page/EventHandler.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 507 matching lines...) Expand 10 before | Expand all | Expand 10 after
518 // Returns the bounding box of the block type node touched by the WebRect. 518 // Returns the bounding box of the block type node touched by the WebRect.
519 WebRect computeBlockBounds(const WebRect&, bool ignoreClipping); 519 WebRect computeBlockBounds(const WebRect&, bool ignoreClipping);
520 520
521 WebCore::IntPoint clampOffsetAtScale(const WebCore::IntPoint& offset, float scale); 521 WebCore::IntPoint clampOffsetAtScale(const WebCore::IntPoint& offset, float scale);
522 522
523 // Exposed for tests. 523 // Exposed for tests.
524 WebVector<WebCompositionUnderline> compositionUnderlines() const; 524 WebVector<WebCompositionUnderline> compositionUnderlines() const;
525 525
526 WebLayerTreeView* layerTreeView() const { return m_layerTreeView; } 526 WebLayerTreeView* layerTreeView() const { return m_layerTreeView; }
527 527
528 bool isPinchZoomable() const;
529
528 private: 530 private:
529 float legibleScale() const; 531 float legibleScale() const;
530 void refreshPageScaleFactorAfterLayout(); 532 void refreshPageScaleFactorAfterLayout();
531 void resumeTreeViewCommits(); 533 void resumeTreeViewCommits();
532 void setUserAgentPageScaleConstraints(WebCore::PageScaleConstraints newConst raints); 534 void setUserAgentPageScaleConstraints(WebCore::PageScaleConstraints newConst raints);
533 float clampPageScaleFactorToLimits(float) const; 535 float clampPageScaleFactorToLimits(float) const;
534 WebCore::IntSize contentsSize() const; 536 WebCore::IntSize contentsSize() const;
535 537
536 void resetSavedScrollAndScaleState(); 538 void resetSavedScrollAndScaleState();
537 539
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
594 596
595 // PageWidgetEventHandler functions 597 // PageWidgetEventHandler functions
596 virtual void handleMouseLeave(WebCore::LocalFrame&, const WebMouseEvent&) OV ERRIDE; 598 virtual void handleMouseLeave(WebCore::LocalFrame&, const WebMouseEvent&) OV ERRIDE;
597 virtual void handleMouseDown(WebCore::LocalFrame&, const WebMouseEvent&) OVE RRIDE; 599 virtual void handleMouseDown(WebCore::LocalFrame&, const WebMouseEvent&) OVE RRIDE;
598 virtual void handleMouseUp(WebCore::LocalFrame&, const WebMouseEvent&) OVERR IDE; 600 virtual void handleMouseUp(WebCore::LocalFrame&, const WebMouseEvent&) OVERR IDE;
599 virtual bool handleMouseWheel(WebCore::LocalFrame&, const WebMouseWheelEvent &) OVERRIDE; 601 virtual bool handleMouseWheel(WebCore::LocalFrame&, const WebMouseWheelEvent &) OVERRIDE;
600 virtual bool handleGestureEvent(const WebGestureEvent&) OVERRIDE; 602 virtual bool handleGestureEvent(const WebGestureEvent&) OVERRIDE;
601 virtual bool handleKeyEvent(const WebKeyboardEvent&) OVERRIDE; 603 virtual bool handleKeyEvent(const WebKeyboardEvent&) OVERRIDE;
602 virtual bool handleCharEvent(const WebKeyboardEvent&) OVERRIDE; 604 virtual bool handleCharEvent(const WebKeyboardEvent&) OVERRIDE;
603 605
606 bool earlyGestureShowPress(const WebCore::PlatformGestureEvent&);
607
604 WebCore::InputMethodContext* inputMethodContext(); 608 WebCore::InputMethodContext* inputMethodContext();
605 WebPlugin* focusedPluginIfInputMethodSupported(WebCore::LocalFrame*); 609 WebPlugin* focusedPluginIfInputMethodSupported(WebCore::LocalFrame*);
606 610
607 WebViewClient* m_client; // Can be 0 (e.g. unittests, shared workers, etc.) 611 WebViewClient* m_client; // Can be 0 (e.g. unittests, shared workers, etc.)
608 WebAutofillClient* m_autofillClient; 612 WebAutofillClient* m_autofillClient;
609 WebSpellCheckClient* m_spellCheckClient; 613 WebSpellCheckClient* m_spellCheckClient;
610 WebPasswordGeneratorClient* m_passwordGeneratorClient; 614 WebPasswordGeneratorClient* m_passwordGeneratorClient;
611 615
612 ChromeClientImpl m_chromeClientImpl; 616 ChromeClientImpl m_chromeClientImpl;
613 ContextMenuClientImpl m_contextMenuClientImpl; 617 ContextMenuClientImpl m_contextMenuClientImpl;
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
762 OwnPtr<FullscreenController> m_fullscreenController; 766 OwnPtr<FullscreenController> m_fullscreenController;
763 767
764 bool m_showFPSCounter; 768 bool m_showFPSCounter;
765 bool m_showPaintRects; 769 bool m_showPaintRects;
766 bool m_showDebugBorders; 770 bool m_showDebugBorders;
767 bool m_continuousPaintingEnabled; 771 bool m_continuousPaintingEnabled;
768 bool m_showScrollBottleneckRects; 772 bool m_showScrollBottleneckRects;
769 WebColor m_baseBackgroundColor; 773 WebColor m_baseBackgroundColor;
770 WebColor m_backgroundColorOverride; 774 WebColor m_backgroundColorOverride;
771 float m_zoomFactorOverride; 775 float m_zoomFactorOverride;
776 bool m_sentEarlyShowPress;
772 }; 777 };
773 778
774 // We have no ways to check if the specified WebView is an instance of 779 // We have no ways to check if the specified WebView is an instance of
775 // WebViewImpl because WebViewImpl is the only implementation of WebView. 780 // WebViewImpl because WebViewImpl is the only implementation of WebView.
776 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true); 781 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true);
777 782
778 } // namespace blink 783 } // namespace blink
779 784
780 #endif 785 #endif
OLDNEW
« no previous file with comments | « Source/core/page/EventHandler.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698