dart2js CPS: implement special handling of the Symbol constructor.

dart2js CPS: implement special handling of the Symbol constructor.

There is a 'const' Symbol constructor that is not expressible as a Dart
const constructor because it performs validation of its input.  This is
implemented in the libraries by using a dummy const constructor definition
that does not validate its input and replacing calls to 'new Symbol' with
calls to 'new Symbol.validated' in the compiler.

Without replacing calls to 'new Symbol', the non-validating dummy
implementation will be used, which is not correct.

Closes #24878.

R=asgerf@google.com
BUG=https://github.com/dart-lang/sdk/issues/24878

Committed: https://github.com/dart-lang/sdk/commit/fd9603d1d26e840b30ec086f67207f34d94579db

[asgerf, 2016-01-27 14:56:32]

LGTM

[Kevin Millikin (Google), 2016-01-28 07:55:44]

Description was changed from

==========
dart2js CPS: implement special handling of the Symbol constructor.

There is a 'const' Symbol constructor that is not expressible as a Dart
const constructor because it performs validation of its input.  This is
implemented in the libraries by using a dummy const constructor definition
that does not validate its input and replacing calls to 'new Symbol' with
calls to 'new Symbol.validated' in the compiler.

Without replacing calls to 'new Symbol', the non-validating dummy
implementation will be used, which is not correct.

Closes #24878.

R=asgerf@google.com
BUG=https://github.com/dart-lang/sdk/issues/24878
==========

to

==========
dart2js CPS: implement special handling of the Symbol constructor.

There is a 'const' Symbol constructor that is not expressible as a Dart
const constructor because it performs validation of its input.  This is
implemented in the libraries by using a dummy const constructor definition
that does not validate its input and replacing calls to 'new Symbol' with
calls to 'new Symbol.validated' in the compiler.

Without replacing calls to 'new Symbol', the non-validating dummy
implementation will be used, which is not correct.

Closes #24878.

R=asgerf@google.com
BUG=https://github.com/dart-lang/sdk/issues/24878

Committed:
https://github.com/dart-lang/sdk/commit/fd9603d1d26e840b30ec086f67207f34d94579db
==========

[Kevin Millikin (Google), 2016-01-28 07:55:46]

Committed patchset #1 (id:1) manually as
fd9603d1d26e840b30ec086f67207f34d94579db (presubmit successful).