Issue 1639253008: Merge to XFA: Fix behaviour of app.alert() with a single object argument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1639253008: Merge to XFA: Fix behaviour of app.alert() with a single object argument. (Closed)

Created:
4 years, 10 months ago by Tom Sepez

Modified:
4 years, 10 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Fix behaviour of app.alert() with a single object argument. Original Review URL: https://codereview.chromium.org/1641693003 . (cherry picked from commit 66519af52b61ca158044651d0507d47efb364f87) TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/bd9325754999c2c3a01562ea090654f1ab07cc59

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+129 lines, -79 lines)			Patch
M	fpdfsdk/src/javascript/JS_Value.h	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Value.cpp	View	2 chunks	+33 lines, -0 lines	0 comments	Download
M	fpdfsdk/src/javascript/app.cpp	View	1 chunk	+35 lines, -75 lines	0 comments	Download
M	samples/pdfium_test.cc	View	1 chunk	+9 lines, -4 lines	0 comments	Download
M	testing/resources/javascript/app_alert.in	View	1 chunk	+26 lines, -0 lines	0 comments	Download
M	testing/resources/javascript/app_alert_expected.txt	View	1 chunk	+14 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

Committed patchset #1 (id:1) manually as bd9325754999c2c3a01562ea090654f1ab07cc59 (presubmit successful).

4 years, 10 months ago (2016-01-29 17:10:46 UTC) #3

Message was sent while issue was closed.

lgtm