Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1639233004: Revert of [mojo] Enable ServiceRegistryImpl to override remote services (Closed)

Created:
4 years, 10 months ago by Noel Gordon
Modified:
4 years, 10 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blink-reviews, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@usb-testing-3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [mojo] Enable ServiceRegistryImpl to override remote services (patchset #12 id:220001 of https://codereview.chromium.org/1470153002/ ) Reason for revert: Causing Oilpan leak bot failure https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/17113 Original issue's description: > [mojo] Enable ServiceRegistryImpl to override remote services > > This adds a new AddServiceOverride method to ServiceRegistryImpl. > The purpose of this is to allow testing code to intercept remote > service connections and opaquely provide a mock implementation of > any service. > > The new interface is also added to the ServiceRegistry's JS > bindings. > > Committed: https://crrev.com/9b0d7173af550086d5688137752a6f70109e9c98 > Cr-Commit-Position: refs/heads/master@{#371736} TBR=jam@chromium.org,reillyg@chromium.org,rockot@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/9660f300aa9a0c508c46eee903663903bf4a456e Cr-Commit-Position: refs/heads/master@{#372061}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -142 lines) Patch
M content/common/mojo/service_registry_impl.h View 3 chunks +4 lines, -12 lines 0 comments Download
M content/common/mojo/service_registry_impl.cc View 3 chunks +5 lines, -14 lines 0 comments Download
M content/renderer/mojo/service_registry_js_wrapper.h View 2 chunks +1 line, -7 lines 0 comments Download
M content/renderer/mojo/service_registry_js_wrapper.cc View 3 chunks +1 line, -32 lines 0 comments Download
M third_party/WebKit/LayoutTests/harness-tests/mojo-helpers.html View 1 chunk +0 lines, -55 lines 0 comments Download
M third_party/WebKit/LayoutTests/resources/mojo-helpers.js View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Noel Gordon
Created Revert of [mojo] Enable ServiceRegistryImpl to override remote services
4 years, 10 months ago (2016-01-28 08:28:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639233004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639233004/1
4 years, 10 months ago (2016-01-28 08:29:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639233004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639233004/1
4 years, 10 months ago (2016-01-28 08:33:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639233004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639233004/1
4 years, 10 months ago (2016-01-28 09:03:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639233004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639233004/1
4 years, 10 months ago (2016-01-28 09:33:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 09:53:44 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 09:54:34 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9660f300aa9a0c508c46eee903663903bf4a456e
Cr-Commit-Position: refs/heads/master@{#372061}

Powered by Google App Engine
This is Rietveld 408576698