Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1020)

Issue 16392011: Move FileEnumerator to its own file, do some refactoring. (Closed)

Created:
7 years, 6 months ago by brettw
Modified:
7 years, 6 months ago
CC:
chromium-reviews, jam, weitaosu+watch_chromium.org, nkostylev+watch_chromium.org, tzik+watch_chromium.org, amit, ahutter, browser-components-watch_chromium.org, chrome-speed-team+watch_google.com, rginda+watch_chromium.org, Raman Kakilate, yfriedman+watch_chromium.org, markusheintz_, stevenjb+watch_chromium.org, kinuko+watch, frankf+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, benquan, grt+watch_chromium.org, kkania, dbeam+watch-autofill_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, bulach+watch_chromium.org, timurrrr+watch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, haitaol1, tim (not reviewing), Dane Wallinga, derat+watch_chromium.org, dcaiafa+watch_chromium.org, wez+watch_chromium.org, Raghu Simha, sanjeevr, craigdh+watch_chromium.org, feature-media-reviews_chromium.org, rmsousa+watch_chromium.org, oshima+watch_chromium.org, ilevy-cc_chromium.org, Albert Bodenhamer, sergeyu+watch_chromium.org, klundberg+watch_chromium.org, rouslan+autofillwatch_chromium.org, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, Ilya Sherman, akalin, tfarina, sail+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, robertshield, davemoore+watch_chromium.org, dyu1, estade+watch_chromium.org, alexeypa+watch_chromium.org, bruening+watch_chromium.org, glider+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Move FileEnumerator to its own file, do some refactoring. It creates a class FileInfo to contain the details rather than using a platform-specific typedef. This allows the accessors GetName, GetSize, etc. to be moved directly to this class (previously they were static helpers on the FileEnumerator class) which makes a bunch of code much cleaner. It also gives reasonable getting and initialization which the previous version lacked. BUG=175002 Reland of 198820 and 298824 Original review = https://codereview.chromium.org/13165005 R=rvargas@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205019

Patch Set 1 #

Patch Set 2 : fix export #

Patch Set 3 : fix incorrect includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+976 lines, -917 lines) Patch
M base/base.gypi View 2 chunks +5 lines, -0 lines 0 comments Download
M base/file_util.h View 3 chunks +3 lines, -111 lines 0 comments Download
M base/file_util.cc View 4 chunks +5 lines, -24 lines 0 comments Download
M base/file_util_posix.cc View 9 chunks +11 lines, -162 lines 0 comments Download
M base/file_util_unittest.cc View 14 chunks +20 lines, -22 lines 0 comments Download
M base/file_util_win.cc View 1 chunk +0 lines, -133 lines 0 comments Download
A base/files/file_enumerator.h View 1 1 chunk +156 lines, -0 lines 0 comments Download
A base/files/file_enumerator.cc View 1 chunk +21 lines, -0 lines 0 comments Download
A base/files/file_enumerator_posix.cc View 1 chunk +160 lines, -0 lines 0 comments Download
A base/files/file_enumerator_win.cc View 1 chunk +149 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/camera_detector.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/contacts/contact_database_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_cache.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/drive/file_cache_metadata.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/file_cache_unittest.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/wallpaper_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/app_pack_updater.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/pnacl/pnacl_component_installer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/swiftshader_component_installer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/widevine_cdm_component_installer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_backend.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/external_pref_loader.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/sandboxed_unpacker_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/file_select_helper.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/history/expire_history_backend.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/history/text_database_manager.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/importer/firefox3_importer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/importer/ie_importer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/native_media_file_util.cc View 3 chunks +8 lines, -14 lines 0 comments Download
M chrome/browser/policy/config_dir_policy_loader.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/printing/printing_layout_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/profiles/profile_shortcut_manager_win.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/shell_integration_win.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/pdf/pdf_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/drive_internals_ui.cc View 3 chunks +11 lines, -14 lines 0 comments Download
M chrome/browser/ui/webui/feedback_ui.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/web_applications/web_app_mac.mm View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/i18n/default_locale_handler.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_file_util.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M chrome/common/extensions/extension_l10n_util.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/common/extensions/unpacker.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/installer/setup/setup_util.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/installer/setup/uninstall.cc View 4 chunks +7 lines, -9 lines 0 comments Download
M chrome/installer/test/alternate_version_generator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/delete_after_reboot_helper.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/installer/util/duplicate_tree_detector.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/util/installer_state.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/installer/util/installer_state_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/installer/util/shell_util.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/installer/util/shell_util_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/test/automation/proxy_launcher.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M chrome/test/chromedriver/chrome/zip.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/chromedriver/util.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/gpu/gpu_pixel_browsertest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/test/mini_installer_test/installer_path_provider.cc View 7 chunks +13 lines, -24 lines 0 comments Download
M chrome/test/perf/generate_profile.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/test/perf/startup_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/reliability/automated_ui_tests.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/test/reliability/page_load_test.cc View 4 chunks +10 lines, -9 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/test/webdriver/webdriver_util.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/test/reliability/page_load_test.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/port_monitor.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M components/autofill/browser/data_driven_test.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M content/browser/gpu/gpu_pixel_browsertest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M content/browser/indexed_db/indexed_db_context_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_flash_file_message_filter.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M content/browser/storage_partition_impl_map.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M content/browser/zygote_host/zygote_host_impl_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/image_decoder_test.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M gpu/config/gpu_info_collector_win.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M gpu/tools/compositor_model_bench/compositor_model_bench.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M media/video/capture/linux/video_capture_device_linux.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M net/base/directory_lister.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/directory_lister.cc View 3 chunks +16 lines, -28 lines 0 comments Download
M net/base/directory_lister_unittest.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M net/disk_cache/block_files_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/disk_cache/cache_util_posix.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M net/disk_cache/simple/simple_index.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/disk_cache/simple/simple_index_file.cc View 4 chunks +9 lines, -10 lines 0 comments Download
M net/tools/dump_cache/dump_files.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M net/tools/quic/quic_in_memory_cache.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/url_request/url_request_file_dir_job.cc View 1 chunk +8 lines, -18 lines 0 comments Download
M net/url_request/url_request_file_job.cc View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/policy_hack/policy_watcher_linux.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M sync/syncable/directory.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/leveldatabase/env_chromium.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/zlib/google/zip.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/zlib/google/zip_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/android/md5sum/md5sum.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M tools/heapcheck/suppressions.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/valgrind/tsan/suppressions.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/database/database_tracker.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M webkit/browser/dom_storage/dom_storage_context.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M webkit/browser/fileapi/isolated_file_util_unittest.cc View 3 chunks +7 lines, -9 lines 0 comments Download
M webkit/browser/fileapi/local_file_util.cc View 6 chunks +8 lines, -11 lines 0 comments Download
M webkit/browser/fileapi/native_file_util.cc View 4 chunks +8 lines, -11 lines 0 comments Download
M webkit/browser/fileapi/sandbox_database_test_helper.cc View 1 2 3 chunks +5 lines, -6 lines 0 comments Download
M webkit/browser/fileapi/sandbox_directory_database.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M webkit/browser/fileapi/sandbox_origin_database.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M webkit/plugins/npapi/plugin_list_mac.mm View 2 chunks +4 lines, -3 lines 0 comments Download
M webkit/plugins/npapi/plugin_list_posix.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
TBR=rvargas This is the same as the original patch with about 2 dozen files updated ...
7 years, 6 months ago (2013-06-07 21:26:45 UTC) #1
brettw
Committed patchset #3 manually as r205019.
7 years, 6 months ago (2013-06-08 04:55:07 UTC) #2
rvargas (doing something else)
7 years, 6 months ago (2013-06-10 17:16:55 UTC) #3
Message was sent while issue was closed.
RBSTMP LGTM

Powered by Google App Engine
This is Rietveld 408576698