Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1639193003: Handle the 'integer' values INFINITY and -INIFINITY in range analysis. (Closed)

Created:
4 years, 10 months ago by Kevin Millikin (Google)
Modified:
4 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle the 'integer' values INFINITY and -INIFINITY in range analysis. Treating the values double.INFINITY and -double.INFINITY as if they were int at compile time also affects the SSA compiler's range analysis pass. This change restores the former behavior that those values were unbounded ranges. R=floitsch@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/9879209bb99221c7df0cb25793dc48a9690df8c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M pkg/compiler/lib/src/ssa/value_range_analyzer.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Kevin Millikin (Google)
4 years, 10 months ago (2016-01-27 11:28:42 UTC) #1
floitsch
LGTM. Could you add a test?
4 years, 10 months ago (2016-01-27 11:56:49 UTC) #2
Kevin Millikin (Google)
4 years, 10 months ago (2016-01-27 12:07:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9879209bb99221c7df0cb25793dc48a9690df8c1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698