Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 1639193002: Improve showTree() debug helper. (Closed)

Created:
4 years, 10 months ago by tkent
Modified:
4 years, 10 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve showTree() debug helper. * <!DOCTYPE> should be shown differently. Old: html 0xhhhhhhhh New: DOCTYPE html 0xhhhhhhhh * Processing Instructions should be shown differently. Old: xml-stylesheet 0xhhhhhhhh New: ?xml-stylesheet 0xhhhhhhhh * Elements and documents show editability Old: body 0xhhhhhhhh New: body 0xhhhhhhhh (editable) This CL has no behaivor changes in production. Committed: https://crrev.com/37588ee9232a0da2454eaadbd88713d60c719f24 Cr-Commit-Position: refs/heads/master@{#371758}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M third_party/WebKit/Source/core/dom/Node.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tkent
yosin@, would you review this please?
4 years, 10 months ago (2016-01-27 07:32:59 UTC) #2
yosin_UTC9
lgtm Such a cool change! This change helps editing team very much! (^_^)b ☺
4 years, 10 months ago (2016-01-27 08:24:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639193002/1
4 years, 10 months ago (2016-01-27 08:25:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-27 08:30:38 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-01-27 08:32:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37588ee9232a0da2454eaadbd88713d60c719f24
Cr-Commit-Position: refs/heads/master@{#371758}

Powered by Google App Engine
This is Rietveld 408576698