Issue 1639183004: dart2js: Another bug fix in CPS term copying.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1639183004: dart2js: Another bug fix in CPS term copying. (Closed)

Created:
4 years, 10 months ago by Kevin Millikin (Google)

Modified:
4 years, 10 months ago

Reviewers:
asgerf, sra1

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js: Another bug fix in CPS term copying. Correctly copy the type mask giving the type of ForeignCode. This fixes a performance regression when copied terms from the compilation cache are used. R=asgerf@google.com, sra@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/bc0bbb9c658b27d27c1960cf7835dec95771ba91

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Kevin Millikin (Google)

4 years, 10 months ago (2016-01-27 13:27:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bc0bbb9c658b27d27c1960cf7835dec95771ba91 (presubmit successful).