chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java - Issue 1639163003: Extract NotificationBuilderBase for holding the arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java

Issue 1639163003: Extract NotificationBuilderBase for holding the arguments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address peter's comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java

index d75b12692d48fd0fcce753315dc13cdc20af94f8..080df48f179b3bc65f131961b5ee1e08e0e5974e 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java

@@ -452,7 +452,7 @@ private void displayNotification(long persistentNotificationId, String origin, S

NotificationConstants.ACTION_CLOSE_NOTIFICATION, persistentNotificationId, origin,

profileId, incognito, tag, -1 /* actionIndex */);

- NotificationBuilder notificationBuilder =

+ NotificationBuilderBase notificationBuilder =

createNotificationBuilder()

.setTitle(title)

.setBody(body)

@@ -500,7 +500,7 @@ private void displayNotification(long persistentNotificationId, String origin, S

}

- private NotificationBuilder createNotificationBuilder() {

+ private NotificationBuilderBase createNotificationBuilder() {

if (useCustomLayouts()) {

return new CustomNotificationBuilder(mAppContext);

}