chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilder.java - Issue 1639163003: Extract NotificationBuilderBase for holding the arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilder.java

Issue 1639163003: Extract NotificationBuilderBase for holding the arguments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: similarity=20 Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilder.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilder.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilder.java

index 112df41bd988d3508d07f481a68997c12dc7cf1e..aa86ba0bfb13f30fa45d41bfe229810cb98b5b5c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilder.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilder.java

@@ -71,7 +71,8 @@ NotificationBuilder addAction(

/**

* Adds an action to the notification for opening the settings screen.

- NotificationBuilder addSettingsAction(int iconId, CharSequence title, PendingIntent intent);

+ NotificationBuilder addSettingsAction(

+ int iconId, @Nullable CharSequence title, @Nullable PendingIntent intent);

/**

* Sets the default notification options that will be used.