Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1639143002: Add quad to cubic bezier conversion utility to SkPath. (Closed)

Created:
4 years, 11 months ago by karandeepb
Modified:
4 years, 10 months ago
Reviewers:
caryclark, reed1
CC:
reviews_skia.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add quad to cubic bezier conversion utility to SkPath. This CL exposes SkConvertQuadToCubic in SkGeometry.h as ConvertQuadToCubic in SkPath.h. BUG=chromium:543671 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1639143002

Patch Set 1 #

Patch Set 2 : Modified comment style. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M include/core/SkPath.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/core/SkPath.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
karandeepb
reed@ PTAL. Thanks.
4 years, 10 months ago (2016-02-05 03:15:31 UTC) #4
karandeepb
On 2016/02/05 03:15:31, karandeepb wrote: > reed@ PTAL. Thanks. This is needed since we need ...
4 years, 10 months ago (2016-02-05 03:41:33 UTC) #5
reed1
seems like a trivial piece of functionality to add to our public API, but it ...
4 years, 10 months ago (2016-02-05 14:32:13 UTC) #7
caryclark
What is the motivation for this?
4 years, 10 months ago (2016-02-05 16:11:17 UTC) #8
karandeepb
On 2016/02/05 16:11:17, caryclark wrote: > What is the motivation for this? I have described ...
4 years, 10 months ago (2016-02-05 16:12:55 UTC) #9
karandeepb
On 2016/02/05 16:12:55, karandeepb wrote: > On 2016/02/05 16:11:17, caryclark wrote: > > What is ...
4 years, 10 months ago (2016-02-09 07:18:36 UTC) #10
caryclark
4 years, 10 months ago (2016-02-09 12:30:55 UTC) #11
Rather than promote this to a public interface, I recommend copying the
implementation to your own repository.

In general, Skia would like to encourage using native types and not rely on
down-converting, since it is imprecise, creates a lot of data, and
time-consuming. It's implementation may change in the future as the calling
needs change (for instance, it could be removed altogether) as rendering evolves
to use native types directly.

Powered by Google App Engine
This is Rietveld 408576698