Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 1639133003: ::before/::after are not features for invalidation. (Closed)

Created:
4 years, 11 months ago by rune
Modified:
4 years, 11 months ago
Reviewers:
Eric Willigers
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

::before/::after are not features for invalidation. We store a flag for finding ::before or ::after in InvalidationSetFeatures, yet they are not added as features to invalidation sets. That means we need to handle *::before as a universal selector and cause subtree invalidations. R=ericwilligers@chromium.org BUG=581675 Committed: https://crrev.com/c3937b7ccbe9b8ad5afd3210831daaac5e2cb213 Cr-Commit-Position: refs/heads/master@{#372035}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -9 lines) Patch
A third_party/WebKit/LayoutTests/fast/css/invalidation/universal-sibling-before.html View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css/invalidation/universal-sibling-before-expected.html View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleFeature.cpp View 1 chunk +17 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
rune
ptal
4 years, 11 months ago (2016-01-28 00:35:14 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639133003/1
4 years, 11 months ago (2016-01-28 00:36:49 UTC) #3
Eric Willigers
lgtm
4 years, 11 months ago (2016-01-28 00:44:59 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-28 01:59:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639133003/1
4 years, 11 months ago (2016-01-28 06:40:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-28 06:45:48 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-28 06:47:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3937b7ccbe9b8ad5afd3210831daaac5e2cb213
Cr-Commit-Position: refs/heads/master@{#372035}

Powered by Google App Engine
This is Rietveld 408576698