chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm - Issue 163913011: [OSX, OmniTheatre] Handle OriginChip click properly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

Issue 163913011: [OSX, OmniTheatre] Handle OriginChip click properly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review fixes. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

index ed6cc3e592d5a27982872b714547a9e6ff000d4e..1777998887526adcc8cceccf1b949b828f4d40ce 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

@@ -775,8 +775,6 @@ void OmniboxViewMac::OnSetFocus(bool control_down) {

model()->OnSetFocus(control_down);

controller()->OnSetFocus();

- // TODO(groby): Not entirely correct, since the chip should only be disabled

- // after mouseDown: was handled, to allow clicking on the origin chip.

if (chrome::ShouldDisplayOriginChipV2()) {

controller()->GetToolbarModel()->set_origin_chip_enabled(false);

controller()->OnChanged();