Issue 163913005: Remove WrapperWorldType from DOMDataStore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 163913005: Remove WrapperWorldType from DOMDataStore (Closed)

Created:
6 years, 10 months ago by haraken

Modified:
6 years, 10 months ago

Reviewers:
dcarney, jochen (gone - plz use gerrit)

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove WrapperWorldType from DOMDataStore I'm removing WrapperWorldType from the code base. What DOMDataStore needs to know is just whether we're in the main world or not. Thus this CL replaces WrapperWorldType with 'bool m_isMainWorld'. BUG=341032 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167338

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -17 lines)			Patch
M	Source/bindings/v8/DOMDataStore.h	View	7 chunks	+8 lines, -8 lines	0 comments	Download
M	Source/bindings/v8/DOMDataStore.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/bindings/v8/DOMWrapperWorld.cpp	View	1 chunk	+1 line, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

haraken

PTAL This is a preparation CL for removing worldType() completely.

6 years, 10 months ago (2014-02-18 12:11:00 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/163913005/1

6 years, 10 months ago (2014-02-18 13:42:43 UTC) #4

Message was sent while issue was closed.

Change committed as 167338

Expand Messages | Collapse Messages