Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 163913003: Fix A64 build: unwrap HSourcePosition into int before recording. (Closed)

Created:
6 years, 10 months ago by Vyacheslav Egorov (Chromium)
Modified:
6 years, 10 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Fix A64 build: unwrap HSourcePosition into int before recording. Remove unused position_ field in the LChunkBuilder. R=ulan@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=19362

Patch Set 1 #

Patch Set 2 : set optimization id #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M src/a64/lithium-a64.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/a64/lithium-a64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/a64/lithium-codegen-a64.cc View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Chromium)
6 years, 10 months ago (2014-02-13 16:48:40 UTC) #1
ulan
lgtm
6 years, 10 months ago (2014-02-13 16:52:29 UTC) #2
Vyacheslav Egorov (Chromium)
6 years, 10 months ago (2014-02-13 16:53:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19362 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698