Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1639093002: Add //mojo/edk/platform/thread_utils.* containing "yield" and "sleep". (Closed)

Created:
4 years, 11 months ago by viettrungluu
Modified:
4 years, 11 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add //mojo/edk/platform/thread_utils.* containing "yield" and "sleep". Remove //mojo/edk/system/test/sleep*. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/25fa89235890e5e9a1581dba3b5f38836b77f9d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -202 lines) Patch
M mojo/edk/base_edk/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A mojo/edk/base_edk/thread_utils.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M mojo/edk/platform/BUILD.gn View 3 chunks +7 lines, -0 lines 0 comments Download
A mojo/edk/platform/thread_utils.h View 1 chunk +24 lines, -0 lines 0 comments Download
A mojo/edk/platform/thread_utils_unittest.cc View 1 chunk +41 lines, -0 lines 0 comments Download
M mojo/edk/system/awakable_list_unittest.cc View 11 chunks +13 lines, -11 lines 0 comments Download
M mojo/edk/system/channel_endpoint.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/core_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M mojo/edk/system/data_pipe_impl_unittest.cc View 12 chunks +11 lines, -10 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher_unittest.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M mojo/edk/system/message_pipe_test_utils.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/raw_channel_unittest.cc View 5 chunks +6 lines, -4 lines 0 comments Download
M mojo/edk/system/remote_message_pipe_unittest.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M mojo/edk/system/simple_dispatcher_unittest.cc View 10 chunks +11 lines, -10 lines 0 comments Download
M mojo/edk/system/test/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D mojo/edk/system/test/sleep.h View 1 chunk +0 lines, -24 lines 0 comments Download
D mojo/edk/system/test/sleep.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D mojo/edk/system/test/sleep_unittest.cc View 1 chunk +0 lines, -50 lines 0 comments Download
M mojo/edk/system/waiter_unittest.cc View 8 chunks +10 lines, -9 lines 0 comments Download
M mojo/edk/util/cond_var_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/util/mutex_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M mojo/edk/util/waitable_event_unittest.cc View 6 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 11 months ago (2016-01-26 23:41:17 UTC) #1
vardhan
lgtm
4 years, 11 months ago (2016-01-27 00:29:44 UTC) #2
viettrungluu
4 years, 11 months ago (2016-01-27 00:32:11 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
25fa89235890e5e9a1581dba3b5f38836b77f9d5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698