src/IceTargetLowering.h - Issue 1639063002: UnimplementedLoweringError's message now includes the instruction name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLowering.h

Issue 1639063002: UnimplementedLoweringError's message now includes the instruction name. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Remove unnecessary include Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceTargetLowering.h

diff --git a/src/IceTargetLowering.h b/src/IceTargetLowering.h

index f8355b93aaa734e2f0da9a9fbfa98f01e9bd521a..3d3452e33d075cb5b085f890a4cb082013e960f3 100644

--- a/src/IceTargetLowering.h

+++ b/src/IceTargetLowering.h

@@ -55,7 +55,8 @@ namespace Ice {

} else { \

/* Use llvm_unreachable instead of report_fatal_error, which gives \

better stack traces. */ \

- llvm_unreachable("Not yet implemented"); \

+ llvm_unreachable( \

+ ("Not yet implemented: " + Instr->getInstName()).c_str()); \

Jim Stichnoth 2016/01/27 22:31:51 The extra level of parentheses is odd, i.e. llvm

abort(); \

} \

} while (0)

« src/IceInst.cpp ('K') | « src/IceInst.cpp ('k') | no next file » | no next file with comments »