Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: src/IceInst.h

Issue 1639063002: UnimplementedLoweringError's message now includes the instruction name. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Remove unnecessary include Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/IceInst.cpp » ('j') | src/IceInst.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceInst.h
diff --git a/src/IceInst.h b/src/IceInst.h
index 85fde52b316fdb67d4f23481a277f92997673838..c1d5bcccff0f2022b48a8115947d0dc7f14f3da8 100644
--- a/src/IceInst.h
+++ b/src/IceInst.h
@@ -76,6 +76,7 @@ public:
};
static_assert(Target <= Target_Max, "Must not be above max.");
InstKind getKind() const { return Kind; }
+ virtual IceString getInstName() const;
InstNumberT getNumber() const { return Number; }
void renumber(Cfg *Func);
@@ -288,6 +289,9 @@ public:
InstArithmetic(Func, Op, Dest, Source1, Source2);
}
OpKind getOp() const { return Op; }
+
+ virtual IceString getInstName() const override;
+
static const char *getOpName(OpKind Op);
bool isCommutative() const;
void dump(const Cfg *Func) const override;
« no previous file with comments | « no previous file | src/IceInst.cpp » ('j') | src/IceInst.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698