Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1639043002: SyncFS: Deleting iterator before closing database. (Closed)

Created:
4 years, 11 months ago by cmumford
Modified:
4 years, 11 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SyncFS: Deleting iterator before closing database. leveldb iterators must be deleted before closing the database or else a crash will ensue. BUG=581474 Committed: https://crrev.com/7294f898b7fe4afbc1bf225d3976eb1b4175f20b Cr-Commit-Position: refs/heads/master@{#371712}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/sync_file_system/local/local_file_change_tracker.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
cmumford
4 years, 11 months ago (2016-01-26 22:11:57 UTC) #2
nhiroki
LGTM. Thank you!
4 years, 11 months ago (2016-01-27 00:19:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639043002/1
4 years, 11 months ago (2016-01-27 03:07:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 03:50:09 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 03:52:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7294f898b7fe4afbc1bf225d3976eb1b4175f20b
Cr-Commit-Position: refs/heads/master@{#371712}

Powered by Google App Engine
This is Rietveld 408576698