Prototype of I/O statistics for Observatory

runtime/vm/service.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/service.h"
 
 #include "include/dart_api.h"
 
 #include "vm/compiler.h"
 #include "vm/coverage.h"
@@ skipping 611 matching lines @@
     JSONObject jsobj(&jsarr);
     frame->PrintToJSONObject(&jsobj);
     // TODO(turnidge): Implement depth differently -- differentiate
     // inlined frames.
     jsobj.AddProperty("depth", i);
   }
   return true;
 }
 
 
+static bool HandleIO(Isolate* isolate, JSONStream* js) {
+  TextBuffer* buffer = js->buffer();
+  Dart_Handle io_lib =
+      Dart_LookupLibrary(Dart_NewStringFromCString("dart:io"));
+  if (Dart_IsError(io_lib)) Dart_PropagateError(io_lib);
+  Dart_Handle result =
+      Dart_Invoke(io_lib,
+                  Dart_NewStringFromCString("_test"),
+                  0,
+                  NULL);
+  if (Dart_IsError(result)) Dart_PropagateError(result);

[Cutch, 2014/02/13 22:42:09]

This code is executing inside the users isolate, in the case that an error
occurs when processing a service request we need to make sure that it is dropped
and does not affect user code. Errors should be reported on the JSONStream
object (see other handlers).

[Søren Gjesse, 2014/02/14 12:10:13]

Done.

+  const char *json;
+  Dart_StringToCString(result, &json);
+  buffer->AddString(json);
+  return true;
+}
+
+
 static bool HandleObjectHistogram(Isolate* isolate, JSONStream* js) {
   ObjectHistogram* histogram = Isolate::Current()->object_histogram();
   if (histogram == NULL) {
     JSONObject jsobj(js);
     jsobj.AddProperty("type", "Error");
     jsobj.AddProperty("text", "Run with --print_object_histogram");
     return true;
   }
   histogram->PrintToJSONStream(js);
   return true;
@@ skipping 456 matching lines @@
   { "classes", HandleClasses },
   { "code", HandleCode },
   { "coverage", HandleCoverage },
   { "debug", HandleDebug },
   { "libraries", HandleLibraries },
   { "objecthistogram", HandleObjectHistogram},
   { "objects", HandleObjects },
   { "profile", HandleProfile },
   { "scripts", HandleScripts },
   { "stacktrace", HandleStackTrace },
+  { "io", HandleIO },
 };
 
 
 static IsolateMessageHandler FindIsolateMessageHandler(const char* command) {
   intptr_t num_message_handlers = sizeof(isolate_handlers) /
                                   sizeof(isolate_handlers[0]);
   for (intptr_t i = 0; i < num_message_handlers; i++) {
     const IsolateMessageHandlerEntry& entry = isolate_handlers[i];
     if (!strcmp(command, entry.command)) {
       return entry.handler;
@@ skipping 85 matching lines @@
   for (intptr_t i = 0; i < num_message_handlers; i++) {
     const RootMessageHandlerEntry& entry = root_handlers[i];
     if (!strcmp(command, entry.command)) {
       return entry.handler;
     }
   }
   return NULL;
 }
 
 }  // namespace dart