Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1639023003: [arc] Don't bring up ScopedIPCSupport for unit tests (Closed)

Created:
4 years, 11 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[arc] Don't bring up ScopedIPCSupport for unit tests This is flakily crashing because it doesn't shut down synchronously between tests, or so it seems. Doesn't matter though because it's no longer necessary for Mojo unless doing actual IPC. R=lhchavez@chromium.org BUG=None Committed: https://crrev.com/46a3160d647f3bb7e72e2dbdefee108ea0e5e63a Cr-Commit-Position: refs/heads/master@{#371663}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M components/arc/arc_bridge_service_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ken Rockot(use gerrit already)
4 years, 11 months ago (2016-01-26 23:25:07 UTC) #1
Luis Héctor Chávez
Bots seem happy. lgtm.
4 years, 11 months ago (2016-01-27 00:34:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639023003/1
4 years, 11 months ago (2016-01-27 00:36:19 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 00:43:47 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 00:44:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46a3160d647f3bb7e72e2dbdefee108ea0e5e63a
Cr-Commit-Position: refs/heads/master@{#371663}

Powered by Google App Engine
This is Rietveld 408576698