Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1639013002: Fix OOPIF-based <webview>. (Closed)

Created:
4 years, 11 months ago by lfg
Modified:
4 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix OOPIF-based <webview>. Cross-process frames are possible in OOPIF-based webview. BUG=578884 Committed: https://crrev.com/6a89374b0877ac5dc0843fbfde090a9dc42b3aa2 Cr-Commit-Position: refs/heads/master@{#371645}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/common/site_isolation_policy.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
lfg
Hey Nick, please take a look.
4 years, 11 months ago (2016-01-26 21:33:05 UTC) #2
Fady Samuel
On 2016/01/26 21:33:05, lfg wrote: > Hey Nick, please take a look. I expect this ...
4 years, 11 months ago (2016-01-26 21:37:35 UTC) #3
lfg
On 2016/01/26 21:37:35, Fady Samuel wrote: > On 2016/01/26 21:33:05, lfg wrote: > > Hey ...
4 years, 11 months ago (2016-01-26 21:50:46 UTC) #4
Fady Samuel
To be clear I'm not blocking this CL. I just think assumptions will definitely break. ...
4 years, 11 months ago (2016-01-26 22:02:56 UTC) #6
Fady Samuel
On 2016/01/26 22:02:56, Fady Samuel wrote: > To be clear I'm not blocking this CL. ...
4 years, 11 months ago (2016-01-26 22:05:29 UTC) #7
ncarter (slow)
lgtm
4 years, 11 months ago (2016-01-26 23:05:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639013002/1
4 years, 11 months ago (2016-01-26 23:08:31 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 00:07:27 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 00:08:16 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a89374b0877ac5dc0843fbfde090a9dc42b3aa2
Cr-Commit-Position: refs/heads/master@{#371645}

Powered by Google App Engine
This is Rietveld 408576698