Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1639003002: Revert of Introduce AndroidFocusRules and NativeWidgetAndroid (Closed)

Created:
4 years, 11 months ago by mfomitchev
Modified:
4 years, 10 months ago
Reviewers:
sadrul, sky, bshe
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Introduce AndroidFocusRules and NativeWidgetAndroid (patchset #13 id:560001 of https://codereview.chromium.org/1403293003/ ) Reason for revert: Reverting the CL as the Android Aura project has been cancelled. Also removing menu_config_android.cc which was added in https://codereview.chromium.org/1477253002. Original issue's description: > Introduce AndroidFocusRules and NativeWidgetAndroid > > NativeWidgetAndroidis very similar to NativeWidgetAura. It > owns a WindowTreeHost and FocusController which initialized > from AndroidFocusRules. Aura on Android should use this > native widget for top level windows. It should create and host > the Widget in a native Android window. > > BUG=507792 > > Committed: https://crrev.com/31db6ee3532c748f40d2ae00514b5d91031d78e7 > Cr-Commit-Position: refs/heads/master@{#360645} TBR=sadrul@chromium.org,sky@chromium.org,bshe@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=507792 Committed: https://crrev.com/70aa1e82edbfcb08314c8bec96daa8983a703880 Cr-Commit-Position: refs/heads/master@{#371918}

Patch Set 1 #

Patch Set 2 : Rebase plus removing menu_config_android.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1170 lines) Patch
M chrome/browser/ui/views/chrome_views_delegate.cc View 1 2 chunks +0 lines, -8 lines 0 comments Download
M ui/views/BUILD.gn View 1 1 chunk +0 lines, -3 lines 0 comments Download
D ui/views/controls/menu/menu_config_android.cc View 1 1 chunk +0 lines, -13 lines 0 comments Download
M ui/views/views.gyp View 1 1 chunk +0 lines, -7 lines 0 comments Download
D ui/views/widget/android/android_focus_rules.h View 1 chunk +0 lines, -28 lines 0 comments Download
D ui/views/widget/android/android_focus_rules.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D ui/views/widget/android/native_widget_android.h View 1 1 chunk +0 lines, -249 lines 0 comments Download
D ui/views/widget/android/native_widget_android.cc View 1 1 chunk +0 lines, -841 lines 0 comments Download
M ui/views/widget/native_widget_aura.h View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
mfomitchev
Created Revert of Introduce AndroidFocusRules and NativeWidgetAndroid
4 years, 11 months ago (2016-01-26 20:55:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639003002/190001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639003002/190001
4 years, 11 months ago (2016-01-26 22:12:24 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/116341) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 11 months ago (2016-01-26 23:21:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1639003002/190001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1639003002/190001
4 years, 11 months ago (2016-01-27 21:17:32 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:190001)
4 years, 10 months ago (2016-01-28 00:15:33 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 00:16:32 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/70aa1e82edbfcb08314c8bec96daa8983a703880
Cr-Commit-Position: refs/heads/master@{#371918}

Powered by Google App Engine
This is Rietveld 408576698