Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1638923002: Compile-time error if mixing class has a factory (Closed)

Created:
4 years, 11 months ago by hausner
Modified:
4 years, 11 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org, gbracha
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Compile-time error if mixin class has a factory The VM now reports the location of the mixin application as well as the location of the illegal constructor in the mixin class. Update test language/mixin_illegal_constructor_test to follow the spec. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/851b4a995c72b484e1b4d13dabbc7e6dcfe7cc24

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -13 lines) Patch
M runtime/vm/class_finalizer.cc View 1 chunk +15 lines, -4 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/language/mixin_illegal_constructor_test.dart View 4 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
hausner
4 years, 11 months ago (2016-01-26 19:05:02 UTC) #3
rmacnak
Commit message: mixing -> mixin lgtm
4 years, 11 months ago (2016-01-26 20:31:49 UTC) #4
hausner
Committed patchset #1 (id:1) manually as 851b4a995c72b484e1b4d13dabbc7e6dcfe7cc24 (presubmit successful).
4 years, 11 months ago (2016-01-26 20:43:53 UTC) #7
hausner
4 years, 11 months ago (2016-01-26 20:44:19 UTC) #8
Message was sent while issue was closed.
Autocorrect :)

Thank you.

Powered by Google App Engine
This is Rietveld 408576698