pkg/compiler/lib/src/ssa/builder.dart - Issue 1638863002: Revert "Optimize subclass/subtype queries"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 1638863002: Revert "Optimize subclass/subtype queries" (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/ssa/builder.dart

diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart

index 0c8e57cef78dbe63d0496fdaa7660a8dfbe73192..ef146154006dfab1e48fbdab30c4641679eba80e 100644

--- a/pkg/compiler/lib/src/ssa/builder.dart

+++ b/pkg/compiler/lib/src/ssa/builder.dart

@@ -4840,7 +4840,8 @@ class SsaBuilder extends ast.Visitor

ClassWorld classWorld = compiler.world;

if (classWorld.isUsedAsMixin(cls)) return true;

- return compiler.world.anyStrictSubclassOf(cls, (ClassElement subclass) {

+ Iterable<ClassElement> subclasses = compiler.world.strictSubclassesOf(cls);

+ return subclasses.any((ClassElement subclass) {

return !rti.isTrivialSubstitution(subclass, cls);

});

}