Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Issue 1638863002: Revert "Optimize subclass/subtype queries" (Closed)

Created:
4 years, 11 months ago by Johnni Winther
Modified:
4 years, 11 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Optimize subclass/subtype queries" This reverts commit 285400c7a73f98da3e3076038d91ddf3ecbbba9e. BUG= Committed: https://github.com/dart-lang/sdk/commit/2affe22138c009a06be421d9f3ad3aa5d144e31e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+488 lines, -1118 lines) Patch
M pkg/compiler/lib/src/elements/elements.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/glue.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/js_emitter.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 4 chunks +4 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/types/union_type_mask.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/class_set.dart View 12 chunks +43 lines, -219 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 8 chunks +27 lines, -110 lines 0 comments Download
M tests/compiler/dart2js/class_set_test.dart View 2 chunks +290 lines, -494 lines 0 comments Download
M tests/compiler/dart2js/world_test.dart View 2 chunks +109 lines, -273 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
TBR
4 years, 11 months ago (2016-01-26 14:24:15 UTC) #2
Johnni Winther
Committed patchset #1 (id:1) manually as 2affe22138c009a06be421d9f3ad3aa5d144e31e (presubmit successful).
4 years, 11 months ago (2016-01-26 14:24:45 UTC) #4
karlklose
4 years, 11 months ago (2016-01-26 14:25:18 UTC) #5
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698