Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 1638793002: cr: Allow passing command line arguments via the run command (Closed)

Created:
4 years, 11 months ago by Sami
Modified:
4 years, 11 months ago
Reviewers:
petrcermak
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cr: Allow passing command line arguments via the run command This patch makes it possible to pass in command line arguments to the run commmand, e.g.: $ cr run chrome https://www.youtube.com The trade-off is that it is no longer possible to run multiple targets using a single command. Committed: https://crrev.com/9a1c85fb7079ce5ffc249c4a787058c81dccdd31 Cr-Commit-Position: refs/heads/master@{#371506}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/cr/cr/commands/run.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Sami
4 years, 11 months ago (2016-01-26 11:24:47 UTC) #3
petrcermak
lgtm LGTM. I think that it's worth the trade-off. Thanks, Petr
4 years, 11 months ago (2016-01-26 14:10:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1638793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1638793002/1
4 years, 11 months ago (2016-01-26 14:11:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 14:35:18 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 14:36:41 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a1c85fb7079ce5ffc249c4a787058c81dccdd31
Cr-Commit-Position: refs/heads/master@{#371506}

Powered by Google App Engine
This is Rietveld 408576698