Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1638773002: Do not check result of SetAlternateDesktop (Closed)

Created:
4 years, 11 months ago by Vitaly Buka (NO REVIEWS)
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not check result of SetAlternateDesktop Fixed regression introduced by https://codereview.chromium.org/1415483008 Seems comment nearby was not noticed. BUG=581134 Committed: https://crrev.com/413e0b007b3f8d41d40915506e4e77a673d2e395 Cr-Commit-Position: refs/heads/master@{#371533}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/service/service_utility_process_host.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Vitaly Buka (NO REVIEWS)
4 years, 11 months ago (2016-01-26 09:10:43 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1638773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1638773002/1
4 years, 10 months ago (2016-01-26 16:36:19 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-26 17:10:53 UTC) #7
Aleksey Shlyapnikov
lgtm
4 years, 10 months ago (2016-01-26 17:36:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1638773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1638773002/1
4 years, 10 months ago (2016-01-26 17:38:12 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-26 17:46:03 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/413e0b007b3f8d41d40915506e4e77a673d2e395 Cr-Commit-Position: refs/heads/master@{#371533}
4 years, 10 months ago (2016-01-26 17:47:40 UTC) #14
rickyz (no longer on Chrome)
4 years, 10 months ago (2016-01-26 18:45:02 UTC) #15
Message was sent while issue was closed.
On 2016/01/26 at 17:47:40, commit-bot wrote:
> Patchset 1 (id:??) landed as
https://crrev.com/413e0b007b3f8d41d40915506e4e77a673d2e395
> Cr-Commit-Position: refs/heads/master@{#371533}

Oops, thanks for catching/fixing this!

Powered by Google App Engine
This is Rietveld 408576698