Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1912)

Unified Diff: Source/modules/encryptedmedia/MediaKeys.cpp

Issue 16387015: Make unprefixed EME APIs use platform and Chromium. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/encryptedmedia/MediaKeys.cpp
diff --git a/Source/modules/encryptedmedia/MediaKeys.cpp b/Source/modules/encryptedmedia/MediaKeys.cpp
index 6d87b29f40dc7f6b0968005d963c178e70e00259..63189f9d3aa2aa16b29ce880a3ca594b35c2d46d 100644
--- a/Source/modules/encryptedmedia/MediaKeys.cpp
+++ b/Source/modules/encryptedmedia/MediaKeys.cpp
@@ -31,7 +31,7 @@
#include "core/dom/EventNames.h"
#include "core/html/HTMLMediaElement.h"
#include "core/platform/UUID.h"
-#include "modules/encryptedmedia/CDM.h"
+#include "core/platform/graphics/CDM.h"
#include "modules/encryptedmedia/MediaKeyMessageEvent.h"
#include "modules/encryptedmedia/MediaKeySession.h"
#include "wtf/HashSet.h"
@@ -40,7 +40,7 @@ namespace WebCore {
PassRefPtr<MediaKeys> MediaKeys::create(const String& keySystem, ExceptionCode& ec)
{
- // From <http://dvcs.w3.org/hg/html-media/raw-file/tip/encrypted-media/encrypted-media.html#dom-media-keys-constructor>:
+ // From <http://dvcs.w3.org/hg/html-media/raw-file/default/encrypted-media/encrypted-media.html#dom-media-keys-constructor>:
// The MediaKeys(keySystem) constructor must run the following steps:
// 1. If keySystem is null or an empty string, throw an INVALID_ACCESS_ERR exception and abort these steps.
@@ -58,6 +58,10 @@ PassRefPtr<MediaKeys> MediaKeys::create(const String& keySystem, ExceptionCode&
// 3. Let cdm be the content decryption module corresponding to keySystem.
// 4. Load cdm if necessary.
OwnPtr<CDM> cdm = CDM::create(keySystem);
+ if (!cdm) {
+ ec = NOT_SUPPORTED_ERR;
+ return 0;
+ }
// 5. Create a new MediaKeys object.
// 5.1 Let the keySystem attribute be keySystem.
@@ -71,22 +75,19 @@ MediaKeys::MediaKeys(const String& keySystem, PassOwnPtr<CDM> cdm)
, m_cdm(cdm)
{
ScriptWrappable::init(this);
- m_cdm->setClient(this);
}
MediaKeys::~MediaKeys()
{
- // From <http://dvcs.w3.org/hg/html-media/raw-file/tip/encrypted-media/encrypted-media.html#dom-media-keys-constructor>:
+ // From <http://dvcs.w3.org/hg/html-media/raw-file/default/encrypted-media/encrypted-media.html#dom-media-keys-constructor>:
// When destroying a MediaKeys object, follow the steps in close().
- for (size_t i = 0; i < m_sessions.size(); ++i) {
+ for (size_t i = 0; i < m_sessions.size(); ++i)
m_sessions[i]->close();
- m_sessions[i]->setKeys(0);
- }
}
PassRefPtr<MediaKeySession> MediaKeys::createSession(ScriptExecutionContext* context, const String& type, Uint8Array* initData, ExceptionCode& ec)
{
- // From <http://dvcs.w3.org/hg/html-media/raw-file/tip/encrypted-media/encrypted-media.html#dom-createsession>:
+ // From <http://dvcs.w3.org/hg/html-media/raw-file/default/encrypted-media/encrypted-media.html#dom-createsession>:
// The createSession(type, initData) method must run the following steps:
// Note: The contents of initData are container-specific Initialization Data.
@@ -99,15 +100,18 @@ PassRefPtr<MediaKeySession> MediaKeys::createSession(ScriptExecutionContext* con
// 2. If type contains a MIME type that is not supported or is not supported by the keySystem, throw
// a NOT_SUPPORTED_ERR exception and abort these steps.
- if (!type.isNull() && !type.isEmpty() && !m_cdm->supportsMIMEType(type)) {
+ ASSERT(!type.isNull() && !type.isEmpty());
+ if (type.isNull() || type.isEmpty() || !m_cdm->supportsMIMEType(type)) {
ec = NOT_SUPPORTED_ERR;
return 0;
}
// 3. Create a new MediaKeySession object.
+ RefPtr<MediaKeySession> session = MediaKeySession::create(context, *m_cdm, this);
// 3.1 Let the keySystem attribute be keySystem.
+ ASSERT(!session->keySystem().isEmpty());
// 3.2 Let the sessionId attribute be a unique Session ID string. It may be generated by cdm.
- RefPtr<MediaKeySession> session = MediaKeySession::create(context, this, keySystem());
+ // This is handled by m_cdm and may happen asynchronously.
// 4. Add the new object to an internal list of session objects.
m_sessions.append(session);
@@ -121,16 +125,12 @@ PassRefPtr<MediaKeySession> MediaKeys::createSession(ScriptExecutionContext* con
void MediaKeys::setMediaElement(HTMLMediaElement* element)
{
+ // FIXME: Cause HTMLMediaElement::setMediaKeys() to throw an exception if m_mediaElement is not 0.
+ // FIXME: Hook up the CDM to the WebMediaPlayer in Chromium.
+ ASSERT(!m_mediaElement);
m_mediaElement = element;
}
-MediaPlayer* MediaKeys::cdmMediaPlayer(const CDM*) const
-{
- if (m_mediaElement)
- return m_mediaElement->player();
- return 0;
-}
-
}
#endif

Powered by Google App Engine
This is Rietveld 408576698