Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 1638653002: test: allow use of system gmock/gtest libs (Closed)

Created:
4 years, 11 months ago by vapier
Modified:
4 years, 11 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

test: allow use of system gmock/gtest libs Some systems provide prebuilt copies of gmock/gtest (such as Chromium OS). Add a configure flag so they can take advantage of that. This allows for a smaller checkout as they don't need to include the full testing/ tree. BUG=chromium:579384 TEST=`make check` passes w/--enable-system-test-libs TEST=`make check` passes w/--disable-system-test-libs R=thestig@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/de54eb133fad11a08396c7698d55a0c22caa4568

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+385 lines, -51 lines) Patch
M Makefile.am View 3 chunks +9 lines, -1 line 0 comments Download
M Makefile.in View 33 chunks +85 lines, -47 lines 0 comments Download
M configure View 7 chunks +256 lines, -1 line 0 comments Download
M configure.ac View 1 chunk +33 lines, -0 lines 0 comments Download
M src/breakpad_googletest_includes.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
vapier
4 years, 11 months ago (2016-01-25 23:48:08 UTC) #2
Lei Zhang
lgtm
4 years, 11 months ago (2016-01-25 23:57:27 UTC) #3
vapier
4 years, 11 months ago (2016-01-26 00:28:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
de54eb133fad11a08396c7698d55a0c22caa4568 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698