Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1638643003: dart2js: Repair a failing assert. (Closed)

Created:
4 years, 11 months ago by Kevin Millikin (Google)
Modified:
4 years, 11 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Repair a failing assert. Now there are more 'is int' doubles than just -0.0. R=asgerf@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/9c79eb0d0511488681594512701343a3619a291c

Patch Set 1 #

Patch Set 2 : Update the comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M pkg/compiler/lib/src/types/constants.dart View 1 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Kevin Millikin (Google)
4 years, 11 months ago (2016-01-26 15:38:14 UTC) #1
asgerf
lgtm
4 years, 11 months ago (2016-01-26 15:42:43 UTC) #2
Kevin Millikin (Google)
4 years, 11 months ago (2016-01-26 15:44:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9c79eb0d0511488681594512701343a3619a291c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698