Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 163863003: Add missing break statement (Closed)

Created:
6 years, 10 months ago by Devlin
Modified:
6 years, 10 months ago
Reviewers:
Finnur
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add missing break statement Add a missing break statement in developer_private_api.cc (I'm actually shocked this didn't cause runtime errors). TBR=finnur@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251226

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 10 months ago (2014-02-13 19:38:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/163863003/1
6 years, 10 months ago (2014-02-13 20:05:15 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 23:06:24 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=201765
6 years, 10 months ago (2014-02-13 23:06:25 UTC) #4
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 10 months ago (2014-02-13 23:08:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/163863003/1
6 years, 10 months ago (2014-02-13 23:10:42 UTC) #6
commit-bot: I haz the power
Change committed as 251226
6 years, 10 months ago (2014-02-14 01:49:55 UTC) #7
Finnur
6 years, 10 months ago (2014-02-14 10:08:42 UTC) #8
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698