Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1638623002: Fix child window checks for single-process mode. (Closed)

Created:
4 years, 11 months ago by jbauman
Modified:
4 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix child window checks for single-process mode. process_->GetProcess() will fail in this case, so don't bother with these checks. In this case they don't matter because the GPU isn't being sandboxed anyway. BUG=580921 Committed: https://crrev.com/006b75cf40c873bcc386bf1ba99b8b63bc1818e9 Cr-Commit-Position: refs/heads/master@{#371704}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -17 lines) Patch
M content/browser/gpu/gpu_process_host.cc View 1 1 chunk +20 lines, -17 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
jbauman
4 years, 11 months ago (2016-01-25 22:16:32 UTC) #3
Ken Russell (switch to Gerrit)
lgtm
4 years, 11 months ago (2016-01-27 01:45:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1638623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1638623002/20001
4 years, 11 months ago (2016-01-27 02:00:42 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-27 03:28:10 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 03:29:16 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/006b75cf40c873bcc386bf1ba99b8b63bc1818e9
Cr-Commit-Position: refs/heads/master@{#371704}

Powered by Google App Engine
This is Rietveld 408576698