Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1638573002: Have WebGeolocationController always wrap up its private controller object (Closed)

Created:
4 years, 11 months ago by sof
Modified:
4 years, 11 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, mlamouri+watch-blink_chromium.org, mvanouwerkerk+watch_chromium.org, blink-reviews, timvolodine
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Have WebGeolocationController always wrap up its private controller object Until Oilpan is firmly enabled, always use GeolocationControllerPrivate to wrap up the non-owned GeolocationController* object. The previous implementation was performing an untidy downcast with undefined behavior; no need for such shortcuts here. R= BUG=581112 Committed: https://crrev.com/209cd7deba6500a0dc82ffbd48bc9522cdf9c1b2 Cr-Commit-Position: refs/heads/master@{#371341}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -19 lines) Patch
M third_party/WebKit/Source/web/WebGeolocationController.cpp View 3 chunks +9 lines, -19 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1638573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1638573002/1
4 years, 11 months ago (2016-01-25 20:42:09 UTC) #2
sof
please take a look. This GeolocationControllerPrivate intermediary will be shortlived iff Oilpan sticks, but best ...
4 years, 11 months ago (2016-01-25 20:43:45 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-25 22:00:04 UTC) #6
haraken
LGTM
4 years, 11 months ago (2016-01-25 22:44:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1638573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1638573002/1
4 years, 11 months ago (2016-01-25 22:47:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-25 22:57:46 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 22:59:28 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/209cd7deba6500a0dc82ffbd48bc9522cdf9c1b2
Cr-Commit-Position: refs/heads/master@{#371341}

Powered by Google App Engine
This is Rietveld 408576698