third_party/WebKit/Source/core/inspector/v8/V8InjectedScriptHost.cpp - Issue 1638563002: DevTools: migrate ScriptFunctionCall off ScriptValue (to be inlined into the InjectedScript.cpp).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/v8/V8InjectedScriptHost.cpp

Issue 1638563002: DevTools: migrate ScriptFunctionCall off ScriptValue (to be inlined into the InjectedScript.cpp). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ready for review Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/InjectedScript.cpp ('K') | « third_party/WebKit/Source/core/inspector/InjectedScript.cpp ('k') | third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp » ('j') | third_party/WebKit/Source/platform/JSONValuesForV8.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/v8/V8InjectedScriptHost.cpp

diff --git a/third_party/WebKit/Source/core/inspector/v8/V8InjectedScriptHost.cpp b/third_party/WebKit/Source/core/inspector/v8/V8InjectedScriptHost.cpp

index d235b349c7a41925b472c45b2c3c4a1e7676b050..65419f703f75413c3146191a54dc8b4d4b18fdaf 100644

--- a/third_party/WebKit/Source/core/inspector/v8/V8InjectedScriptHost.cpp

+++ b/third_party/WebKit/Source/core/inspector/v8/V8InjectedScriptHost.cpp

@@ -263,7 +263,8 @@ void V8InjectedScriptHost::inspectCallback(const v8::FunctionCallbackInfo<v8::Va

InjectedScriptHost* host = V8InjectedScriptHost::unwrap(info.GetIsolate()->GetCurrentContext(), info.Holder());

ScriptState* scriptState = ScriptState::current(info.GetIsolate());

- host->inspectImpl(toJSONValue(scriptState->isolate(), info[0]), toJSONValue(scriptState->isolate(), info[1]));

+ ScriptState::Scope scope(scriptState);

+ host->inspectImpl(toJSONValue(scriptState->context(), info[0]), toJSONValue(scriptState->context(), info[1]));

}

void V8InjectedScriptHost::evalCallback(const v8::FunctionCallbackInfo<v8::Value>& info)