Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1638493003: Disabling memory.memory_mobile and memory.blink_mobile_memory on android. (Closed)

Created:
4 years, 11 months ago by RobertoCN
Modified:
4 years, 11 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disabling memory.memory_mobile and memory.blink_mobile_memory on android. crbug.com/581147 and crbug.com/581119 R=sullivan,eakuefner,nednguyen CC=bashi BUG=581119 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect Committed: https://crrev.com/c6bbd67055838de0b0d70bf8881ca5429d220c3e Cr-Commit-Position: refs/heads/master@{#371389}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressing feedback. #

Patch Set 3 : Addressing feedback. Again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/perf/benchmarks/memory.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/memory_infra.py View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
RobertoCN
4 years, 11 months ago (2016-01-25 22:17:20 UTC) #1
nednguyen
https://codereview.chromium.org/1638493003/diff/1/tools/perf/benchmarks/memory.py File tools/perf/benchmarks/memory.py (right): https://codereview.chromium.org/1638493003/diff/1/tools/perf/benchmarks/memory.py#newcode12 tools/perf/benchmarks/memory.py:12: @benchmark.Disabled('android') # crbug.com/581147 You want to do Disabled('all') instead.
4 years, 11 months ago (2016-01-25 22:18:33 UTC) #3
nednguyen
lgtm
4 years, 11 months ago (2016-01-25 23:02:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1638493003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1638493003/40001
4 years, 11 months ago (2016-01-25 23:04:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1638493003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1638493003/40001
4 years, 11 months ago (2016-01-26 00:45:01 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-26 00:54:47 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 00:57:42 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c6bbd67055838de0b0d70bf8881ca5429d220c3e
Cr-Commit-Position: refs/heads/master@{#371389}

Powered by Google App Engine
This is Rietveld 408576698